Skip to content

Add the new test cases, update the SERVLET_VERSION suffix to point to the newly published images#18410

Merged
trask merged 2 commits into
open-telemetry:mainfrom
Channyboy:UpdateOpenLibertySmokeTests26Part2
Apr 30, 2026
Merged

Add the new test cases, update the SERVLET_VERSION suffix to point to the newly published images#18410
trask merged 2 commits into
open-telemetry:mainfrom
Channyboy:UpdateOpenLibertySmokeTests26Part2

Conversation

@Channyboy

@Channyboy Channyboy commented Apr 29, 2026

Copy link
Copy Markdown
Contributor

Second part of #17779 and #18344

@Channyboy Channyboy requested a review from a team as a code owner April 29, 2026 18:38
@trask trask requested a review from Copilot April 29, 2026 20:00

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Liberty smoke test coverage to include the newly published OpenLiberty 26.0.0.3 servlet images, and bumps the shared servlet smoke-test image tag suffix so tests pull the latest published images from GHCR.

Changes:

  • Add new @AppServer test variants for OpenLiberty 26.0.0.3 across multiple JDKs (including OpenJ9 variants) in LibertySmokeTest.
  • Add a servlet-only Liberty smoke test variant for OpenLiberty 26.0.0.3 (JDK 11).
  • Update TestImageVersions.SERVLET_VERSION to the new published servlet image tag suffix.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
smoke-tests/src/test/java/io/opentelemetry/smoketest/appserver/LibertySmokeTest.java Adds OpenLiberty 26.0.0.3 test matrix entries (JDK 8/11/17/21/25, HotSpot + OpenJ9).
smoke-tests/src/test/java/io/opentelemetry/smoketest/appserver/LibertyServletOnlySmokeTest.java Adds servlet-only coverage for OpenLiberty 26.0.0.3 on JDK 11.
smoke-tests/src/test/java/io/opentelemetry/smoketest/TestImageVersions.java Bumps the shared servlet image tag suffix used by all servlet smoke-test images.

Comment on lines +46 to +49
/*
* OpenLiberty 21.0.0.12
*/

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(and same below)

Suggested change
/*
* OpenLiberty 21.0.0.12
*/

@trask

trask commented Apr 29, 2026

Copy link
Copy Markdown
Member

hey @Channyboy, also check CI, looks like a real failure (as opposed to the sporadic variety)

@Channyboy Channyboy force-pushed the UpdateOpenLibertySmokeTests26Part2 branch from bb45273 to eaca483 Compare April 30, 2026 19:42
@Channyboy Channyboy force-pushed the UpdateOpenLibertySmokeTests26Part2 branch from eaca483 to 29cac57 Compare April 30, 2026 19:45
@trask trask enabled auto-merge (squash) April 30, 2026 20:07
@trask trask merged commit 881f642 into open-telemetry:main Apr 30, 2026
93 checks passed
@otelbot

otelbot Bot commented Apr 30, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution @Channyboy! 🎉 We would like to hear from you about your experience contributing to OpenTelemetry by taking a few minutes to fill out this survey.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants